Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_checker: provide indication of new dependencies for ring0 packages #1039

Open
jberry-suse opened this issue Aug 1, 2017 · 5 comments
Open

Comments

@jberry-suse
Copy link
Contributor

Source request: https://progress.opensuse.org/issues/15016:

Assume this scenario:

take the package util-linux: it is in ring0
a new submission comes in, that newly adds: 'BuildRequires: procps'
We add util-linux to Staging:A (as it's a ring0 package)
procps is currently in ring1
util-linux will build 'just fine' in Staging:A - as procps is there (from earlier builds)
so the staging eventually turns green
we accept util-linux into openSUSE:Factory, which in turn mean:
util-linux in Rings:0-Bootstrap can no longer build, as procps is now missing there (and we can't bootstrap the OS anymore)
there are two solutions: move procpos to ring0 (not cool: it depends on systemd-mini) or revert the change on util-linux
=> it would be good to see such breakage before we accept and have the issue effectlively in Ring0

Likely, a comment on the request and an added review for factory-maintainers or similar?

@jberry-suse
Copy link
Contributor Author

Presumably, the new dependencies is not so much the item of interest as much as dependencies from a lower ring (ie ring-1).

@jberry-suse jberry-suse added the P4 label Aug 24, 2017
@DimStar77
Copy link
Contributor

I think on ring1/2 this is not so much of a problem, as those things are actually seen usually, due to the split LETTER/LETTER:DVD

The problem with ring0 packages is that they are also in LETTER (in the ring0 enabled stagings), and this simply can consume everything in ring1 - definitively not what we want.

Just had a case again today, i.e.

rpm update, new dependency on /usr/bin/python (python2-base); python2-base being a ring1 package, this would not cause any extra warning that this rpm package would completely mess up ring0 (luckily, this provoked a couple build fails, which made us catch it)

@jberry-suse
Copy link
Contributor Author

Out of curiosity, why is the ring project separation not carried down into stagings? Would seem far more straight forward than tip-toeing around the issue.

  • Staging:A:0-Bootstrap
  • Staging:A:1-MinimalX
  • Staging:A:2-TestDVD

That would have been seemingly the most straight forward way to setup stagings in light of rings. Presumably that would also solve the hidden dependency issue as well.

@coolo
Copy link
Member

coolo commented Jun 6, 2019

I don't see why we need this - wouldn't this cause the cycle to grow? @DimStar77 ?

@coolo coolo added this to the Repo Checker milestone Jun 6, 2019
@DimStar77
Copy link
Contributor

I don't see why we need this - wouldn't this cause the cycle to grow? @DimStar77 ?

One would expect so, yes - but pretty sure the issues mentioned above were somehow not caught by it (or the cycle checker did not really work back then, also a possibility - there are still chances that OBS misses cycles - purely based on feelings)

@jberry-suse jberry-suse removed this from the Repo Checker milestone Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants