Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new role that allows to trigger rebuilds #2094

Open
lnussel opened this issue Aug 30, 2016 · 18 comments
Open

create new role that allows to trigger rebuilds #2094

lnussel opened this issue Aug 30, 2016 · 18 comments
Labels
Feature Frontend Things related to the OBS RoR app

Comments

@lnussel
Copy link
Member

lnussel commented Aug 30, 2016

OBS all too often needs somebody who can manually trigger rebuilds. That role should not necessarily have full access to modify packages or review requests. Therefore separate from maintainer and reviewer.
Examples where this would be useful are the distro projects, staging and ports.

@bgeuken bgeuken added Feature Frontend Things related to the OBS RoR app labels Aug 31, 2016
@hennevogel
Copy link
Member

Can you explain why only triggering builds is needed?

@lnussel
Copy link
Member Author

lnussel commented Oct 24, 2016

random build failures spoil the fun. I check in stuff, obs works on it over night or weekend and produces random build failures. If I have to review and trigger those myself Monday morning we lose time. If there was a role for triggering rebuilds more community person could help.

@adrianschroeter
Copy link
Member

Having random build failures means you have a not maintainable distribution IMHO. I am not sure if we want to have a role for that. In first place we should find the reason for random failures and work on that.

Has anything changed lately that this is needed suddenly? Any new errors which do appear?

@lnussel
Copy link
Member Author

lnussel commented Oct 24, 2016

you are welcome to play staging master for a week or so

@DimStar77
Copy link
Contributor

random build failures include: syswrite: no disk space

@coolo
Copy link
Member

coolo commented Oct 24, 2016

those are actually supposed to be handled as bad jobs. build greps for errors like that.

@adrianschroeter
Copy link
Member

yep, do you have examples where it did not work?

However, you should add constraints to avoid wasting our build power by too many attempts just by accident finding a proper build host.

(seems my mail answer is lost .... )

@lnussel
Copy link
Member Author

lnussel commented Oct 25, 2016

Result of tonight's Leap stagings are failures of gdb, graphviz, libkolab-qt5, java-1_7_0-openjdk-bootstrap. Only in the graphviz looks like a worker related issue, the other are random build failures due to races in make -j or whatever.

In graphviz case:
[29380s] ### WATCHDOG MARKER END ###
[29380s] No buildstatus set, either the base system is broken (kernel/initrd/udev/glibc/bash/perl)
[29380s] or the build host has a kernel or hardware problem...

Job seems to be stuck here, killed. (after 28800 seconds of inactivity)

@adrianschroeter
Copy link
Member

can you please store the entire build log the next time when it failed? it is gone now...

@adrianschroeter
Copy link
Member

On Montag, 24. Oktober 2016, 08:04:07 CEST wrote Dominique Leuenberger:

random build failures include: syswrite: no disk space

this means you lack _constraints in first place.

But IMHO we have also code which should mark this job as badhost result.
Do you have an example where it did not work?

Adrian Schroeter
email: [email protected]

SUSE Linux GmbH, GF: Felix Imend�rffer, Jane Smithard, Graham Norton, HRB 21284 (AG N�rnberg)

Maxfeldstra�e 5
90409 N�rnberg
Germany

@lnussel
Copy link
Member Author

lnussel commented Jun 20, 2017

Any update here?

We have one person applying to participate in release management tasks and we don't want to hand out maintainer privileges right away...

Maybe the privilege could also be used for the /status route then. So someone going over build fails can also take notes without requiring to be maintainer. https://build.opensuse.org/project/status/openSUSE:Leap:42.3

@adrianschroeter
Copy link
Member

definitly not a role for this, since it makes the permission checks way more complex.

we may can think about some trigger system for specific commands via tokens, like we do for service runs instead.

@dirkmueller
Copy link
Member

@adrianschroeter any update on the implementation status of the tokens support?

@lnussel
Copy link
Member Author

lnussel commented Jan 7, 2019

hmm, I wonder if we could do this via attributes. We could introduce an attribute settable staging-managers that indicates the requirement to trigger a rebuild on a specific package. Privileged bots could query that regularly and execute the rebuild. That would also allow to defer or block triggering rebuilding to eg when there is a checkin next time. After all it's sometimes desirable to get isos and ftp tree done first.

@coolo
Copy link
Member

coolo commented Jan 7, 2019

that brings me back to an rabbitmq event when an attribute value is created :)

It sounds like an easy enough approach - a little quirky, but very OBSish :)

@ggardet
Copy link
Member

ggardet commented Feb 15, 2019

Related PR: #6965

@dirkmueller
Copy link
Member

the previously implemented behavior has been broken with further changes, so there is a followup PR to add tests and fix it to work again:

#15119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

8 participants