[web] Blur and grayscale aria-hidden and inert div nodes#564
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 12, 2023
This comment was marked as outdated.
This comment was marked as outdated.
dgdavid
changed the title
aria-hidden and inert div nodes
As an attempt to make the UI visually consistent with the accessibility state, grayscale and blur `inert` and `aria-hidden` div nodes.
dgdavid
changed the title
aria-hidden and inert div nodesaria-hidden and inert div nodes
imobachgs
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While the sidebar is open, the rest of the content is inert and aria hidden. This on purpose, done in #563.
But there is no is not enough visual hints about this neither, when the Agama sidebar is open nor a PatternFly Modal is displayed.
Solution
To use some CSS filters to make more evident what is going on. Grayscale and blur, to be more precise.
Testing
Notes
There were some issues with modal dialogs. See comments marked as outdated and/or read #580 to know more.
Screenshots
Click to show/hide screenshots