Skip to content

Update test to setting nomination pool's metadata to reflect new event #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockbmb merged 1 commit into from
Jul 30, 2025
Merged

Update test to setting nomination pool's metadata to reflect new event #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/kusama/src/__snapshots__/kusama.nominationPools.e2e.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,6 @@ exports[`Kusama Nomination Pools > nomination pool metadata test > set metadata
{
"data": {
"caller": "HNZata7iMYWmk5RvZRTiAsSDhV8366zq2YGb3tLH5Upf74F",
"poolId": "(rounded 220)",
},
"method": "MetadataUpdated",
"section": "nominationPools",
Expand Down
1 change: 0 additions & 1 deletion packages/polkadot/src/__snapshots__/polkadot.nominationPools.e2e.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,6 @@ exports[`Polkadot Nomination Pools > nomination pool metadata test > set metadat
{
"data": {
"caller": "15oF4uVJwmo4TdGW7VfQxNLavjCXviqxT9S1MgbjMNHr6Sp5",
"poolId": "(rounded 330)",
},
"method": "MetadataUpdated",
"section": "nominationPools",
Expand Down
5 changes: 3 additions & 2 deletions packages/shared/src/nomination-pools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,8 +660,9 @@ async function nominationPoolSetMetadataTest<

await client.dev.newBlock()

/// TODO: no events are emitted here pending a PR to `pallet_nomination_pools`.
await checkEvents(setMetadataEvents, 'nominationPools').toMatchSnapshot('set metadata events')
await checkEvents(setMetadataEvents, 'nominationPools')
.redact({ removeKeys: /poolId/ })
.toMatchSnapshot('set metadata events')

/// Check the set metadata

Expand Down