Skip to content

Commit 20d9db0

Browse files
committed
fix(demoing-storybook): use " for stories glob to support windows
1 parent dc2eef7 commit 20d9db0

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

packages/create/src/generators/app-lit-element/templates/_package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"license": "MIT",
44
"scripts": {
55
"start": "es-dev-server --app-index index.html --node-resolve --open --watch",
6-
"storybook": "start-storybook --stories 'components/*/stories/*.stories.{js,mdx}' --node-resolve --watch --open",
7-
"storybook:build": "build-storybook --stories 'components/*/stories/*.stories.{js,mdx}'"
6+
"storybook": "start-storybook --stories \"components/*/stories/*.stories.{js,mdx}\" --node-resolve --watch --open",
7+
"storybook:build": "build-storybook --stories \"components/*/stories/*.stories.{js,mdx}\""
88
},
99
"dependencies": {
1010
"lit-html": "^1.0.0",

packages/demoing-storybook/MIGRATION.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
- [From version 0.3.x to 0.4.0](#from-version-03x-to-040)
77
- [Storybook Upgrade from 5.1.x to 5.3.x](#storybook-upgrade-from-51x-to-53x)
88
- [Dependency changes](#dependency-changes)
9-
- [Removed `default-storybook-webpack-config.js`](#removed-default-storybook-webpack-configjs)
10-
- [Replaced `withClassPropertiesKnobs` with a decorator `withWebComponentsKnobs`](#replaced-withclasspropertiesknobs-with-a-decorator-withwebcomponentsknobs)
9+
- [Removed default-storybook-webpack-config.js](#removed-default-storybook-webpack-configjs)
10+
- [Replaced withClassPropertiesKnobs with a decorator withWebComponentsKnobs](#replaced-withclasspropertiesknobs-with-a-decorator-withwebcomponentsknobs)
1111

1212
If you did not modify your configurations then you can upgrade to the latest version by rerunning the generator.
1313

@@ -79,8 +79,8 @@ If you had a custom `require.context` which is different to the default `./stori
7979

8080
```json
8181
"scripts": {
82-
"storybook": "start-storybook --stories 'some/path/to/stories/*.stories.{js,mdx}' --node-resolve --watch --open",
83-
"storybook:build": "build-storybook --stories 'some/path/to/stories/*.stories.{js,mdx}'"
82+
"storybook": "start-storybook --stories \"some/path/to/stories/*.stories.{js,mdx}\" --node-resolve --watch --open",
83+
"storybook:build": "build-storybook --stories \"some/path/to/stories/*.stories.{js,mdx}\""
8484
},
8585
```
8686

packages/demoing-storybook/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
"scripts": {
2222
"build:start": "es-dev-server --root-dir static-storybook --app-index index.html --open",
2323
"prepublishOnly": "../../scripts/insert-header.js",
24-
"site:build": "node src/build/cli.js --stories 'demo/stories/*.stories.{js,mdx}' --config-dir demo/.storybook -o ../../_site/demoing-storybook",
25-
"storybook": "node src/start/cli.js --stories 'packages/demoing-storybook/demo/stories/*.stories.{js,mdx}' --config-dir packages/demoing-storybook/demo/.storybook --root-dir ../../ --node-resolve --watch --open",
26-
"storybook:build": "node src/build/cli.js --stories 'demo/stories/*.stories.{js,mdx}' --config-dir demo/.storybook"
24+
"site:build": "node src/build/cli.js --stories \"demo/stories/*.stories.{js,mdx}\" --config-dir demo/.storybook -o ../../_site/demoing-storybook",
25+
"storybook": "node src/start/cli.js --stories \"packages/demoing-storybook/demo/stories/*.stories.{js,mdx}\" --config-dir packages/demoing-storybook/demo/.storybook --root-dir ../../ --node-resolve --watch --open",
26+
"storybook:build": "node src/build/cli.js --stories \"demo/stories/*.stories.{js,mdx}\" --config-dir demo/.storybook"
2727
},
2828
"files": [
2929
"*.js",

0 commit comments

Comments
 (0)