Skip to content

Commit 24ca118

Browse files
committed
feat!: require node >= 14
this allows us to use the analyzer without a build
1 parent 010bada commit 24ca118

File tree

3 files changed

+7
-29
lines changed

3 files changed

+7
-29
lines changed

.github/workflows/verify-node.yml

+2-13
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,15 @@ jobs:
1212
runs-on: ubuntu-latest
1313
strategy:
1414
matrix:
15-
node-version: [12.x, 14.x]
15+
node-version: [14.x, 16.x]
1616
steps:
1717
- uses: actions/checkout@v2
1818

1919
- name: Setup Node ${{ matrix.node-version }}
2020
uses: actions/setup-node@v2
2121
with:
2222
node-version: ${{ matrix.node-version }}
23-
24-
- name: Get yarn cache directory path
25-
id: yarn-cache-dir-path
26-
run: echo "::set-output name=dir::$(yarn cache dir)"
27-
28-
- uses: actions/cache@v2
29-
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
30-
with:
31-
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
32-
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
33-
restore-keys: |
34-
${{ runner.os }}-yarn-
23+
cache: 'yarn'
3524

3625
- name: Install dependencies
3726
run: yarn --frozen-lockfile

.github/workflows/verify-windows.yml

+3-14
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,11 @@ jobs:
1818
1919
- uses: actions/checkout@v2
2020

21-
- name: Setup Node 12.x
21+
- name: Setup Node 14.x
2222
uses: actions/setup-node@v2
2323
with:
24-
node-version: 12.x
25-
26-
- name: Get yarn cache directory path
27-
id: yarn-cache-dir-path
28-
run: echo "::set-output name=dir::$(yarn cache dir)"
29-
30-
- uses: actions/cache@v2
31-
id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
32-
with:
33-
path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
34-
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
35-
restore-keys: |
36-
${{ runner.os }}-yarn-
24+
node-version: 14.x
25+
cache: 'yarn'
3726

3827
- name: Install dependencies
3928
run: yarn --frozen-lockfile

src/create.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import { AppMixin } from './generators/app/index.js';
99

1010
(async () => {
1111
try {
12-
if (semver.lte(process.version, '10.12.0')) {
13-
console.log(chalk.bgRed('\nUh oh! Looks like you dont have Node v10.12.0 installed!\n'));
12+
if (!semver.gte(process.version, '14.0.0')) {
13+
console.log(chalk.bgRed('\nUh oh! Looks like you dont have Node v14 installed!\n'));
1414
console.log(`You can do this by going to ${chalk.underline.blue(`https://nodejs.org/`)}
1515
1616
Or if you use nvm:

0 commit comments

Comments
 (0)