Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace EventEmitter with EventTarget #3

Open
confususs opened this issue Sep 11, 2019 · 2 comments
Open

Replace EventEmitter with EventTarget #3

confususs opened this issue Sep 11, 2019 · 2 comments

Comments

@confususs
Copy link
Contributor

Version

(no versions yet)

File / Feature

  • src/autoplay.ts
  • src/client.ts
  • src/media.ts
  • src/reconnectable-transport.ts
  • src/session-media.ts
  • src/session-stats.ts

Summary

I assumed that when the browser supports WebRTC it would also support EventTarget, but that is not always the case. (looking at you "Safari")

Screenshot_2019-09-11_10-01-51
Screenshot_2019-09-11_10-02-31

I'm guessing we should keep using EventEmitter, it does not add additional package overhead because that is also used by sip.js.

Screenshot_2019-09-11_10-06-39
@confususs confususs changed the title Replace EventEmitter with EventTarget? Replace EventEmitter with EventTarget Sep 11, 2019
@confususs
Copy link
Contributor Author

Just putting this here for documentation purposes & triggering possible discussions

@c0deaddict
Copy link
Member

We could also use a polyfill for Safari: https://www.npmjs.com/package/event-target-shim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c0deaddict @confususs