From a308e355c608cbc337cc4a812e0c4ec9970b0263 Mon Sep 17 00:00:00 2001 From: dagmar Date: Thu, 2 Jun 2022 14:11:53 +0200 Subject: [PATCH 1/4] adding localstream to disconnect on mute --- demo/components/c-session.mjs | 15 +++++++++++++++ src/session-media.ts | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/demo/components/c-session.mjs b/demo/components/c-session.mjs index 602f96ff..b4166867 100644 --- a/demo/components/c-session.mjs +++ b/demo/components/c-session.mjs @@ -80,6 +80,9 @@ window.customElements.define( case 'unhold': this.session && this.session.unhold(); break; + case 'toggleMute': + this.toggleMute(); + break; case 'hangup': this.session && (await this.session.terminate()); break; @@ -92,6 +95,18 @@ window.customElements.define( } } + toggleMute() { + if (this.session) { + this.session.media.input.muted = !this.session.media.input.muted; + } + } + + setMute(mute) { + this.session.media.input.muted !== mute + ? (this.session.media.input.muted = mute) + : this.session.media.input.muted; + } + connectedCallback() { const template = document.querySelector('[data-component=c-session]'); this.appendChild(template.content.cloneNode(true)); diff --git a/src/session-media.ts b/src/session-media.ts index c2046bc4..c76d3b89 100644 --- a/src/session-media.ts +++ b/src/session-media.ts @@ -196,7 +196,7 @@ export class SessionMedia extends EventEmitter implements ISessionMedia { private setInputMuted(newMuted: boolean) { if (this.inputNode) { if (newMuted) { - this.inputNode.disconnect(); + this.inputNode.disconnect((this.session as any).__streams.localStream); } else { this.inputNode.connect((this.session as any).__streams.localStream); } From 3a044a9803ed00e3338b9e79dbc56be5baea4fe7 Mon Sep 17 00:00:00 2001 From: dagmar Date: Thu, 2 Jun 2022 14:12:55 +0200 Subject: [PATCH 2/4] update packages --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index fd19072a..9e3f513c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "webphone-lib", - "version": "0.2.18", + "version": "0.2.19", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 9ba0f7a2..5cba80b6 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "webphone-lib", - "version": "0.2.18", + "version": "0.2.19", "description": "Webphone Lib", "author": "Open VoIP Alliance", "license": "MIT", From 6bfcf99f94446f6d5ccbe27d2bb4c4dfdf15de63 Mon Sep 17 00:00:00 2001 From: dagmar Date: Thu, 2 Jun 2022 14:18:42 +0200 Subject: [PATCH 3/4] small update in demo page to test --- demo/components/c-session.mjs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/demo/components/c-session.mjs b/demo/components/c-session.mjs index b4166867..44e06992 100644 --- a/demo/components/c-session.mjs +++ b/demo/components/c-session.mjs @@ -75,9 +75,11 @@ window.customElements.define( } break; case 'hold': + this.setMute(true); this.session && this.session.hold(); break; case 'unhold': + this.setMute(false); this.session && this.session.unhold(); break; case 'toggleMute': From fe44f2c60ec1d973fb077561e0a77f518ad668ef Mon Sep 17 00:00:00 2001 From: dagmar Date: Fri, 3 Jun 2022 10:16:22 +0200 Subject: [PATCH 4/4] apply suggestions --- demo/components/c-session.mjs | 4 +--- package-lock.json | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/demo/components/c-session.mjs b/demo/components/c-session.mjs index 44e06992..14a3d9a1 100644 --- a/demo/components/c-session.mjs +++ b/demo/components/c-session.mjs @@ -104,9 +104,7 @@ window.customElements.define( } setMute(mute) { - this.session.media.input.muted !== mute - ? (this.session.media.input.muted = mute) - : this.session.media.input.muted; + this.session.media.input.muted = mute; } connectedCallback() { diff --git a/package-lock.json b/package-lock.json index 9e3f513c..300ed0c5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "webphone-lib", - "version": "0.2.19", + "version": "0.2.20", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 5cba80b6..a71f0d50 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "webphone-lib", - "version": "0.2.19", + "version": "0.2.20", "description": "Webphone Lib", "author": "Open VoIP Alliance", "license": "MIT",