diff --git a/.chloggen/fix-mssql-metric-db-type.yaml b/.chloggen/fix-mssql-metric-db-type.yaml new file mode 100644 index 0000000000..79ff47d9aa --- /dev/null +++ b/.chloggen/fix-mssql-metric-db-type.yaml @@ -0,0 +1,22 @@ +# Use this changelog template to create an entry for release notes. +# +# If your change doesn't affect end users you should instead start +# your pull request title with [chore] or use the "Skip Changelog" label. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: breaking + +# The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) +component: db + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: The `db.type` property value for metrics has been changed to `mssql_instance` to be consistent with spans. + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +# The values here must be integers. +issues: [1779] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: diff --git a/docs/database/mssql.md b/docs/database/mssql.md index 5dd0dd1e80..e6e4e6b9dd 100644 --- a/docs/database/mssql.md +++ b/docs/database/mssql.md @@ -114,6 +114,6 @@ and SHOULD be provided **at span creation time** (if provided at all): Microsoft SQL Server client instrumentations SHOULD collect metrics according to the general [Semantic Conventions for Database Client Metrics](database-metrics.md). -`db.system` MUST be set to `"mssql"`. +`db.system` MUST be set to `"microsoft.sql_server"`. [DocumentStatus]: https://opentelemetry.io/docs/specs/otel/document-status