-
Notifications
You must be signed in to change notification settings - Fork 280
Add initial experimental .NET CLR runtime metrics #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmolkova
merged 36 commits into
open-telemetry:main
from
stevejgordon:dotnet-runtime-metrics
Aug 23, 2024
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
54833c4
Add initial experimental .NET CLR runtime metrics
stevejgordon c6b3628
Fixing lint failures
stevejgordon c80a739
PR feedback
stevejgordon 8cc3175
Update model/metrics/clr-metrics.yaml
stevejgordon 6b0a6e9
Update model/metrics/clr-metrics.yaml
stevejgordon 866a85c
Regen after generator fixes
stevejgordon 8f95fd1
Update model/metrics/clr-metrics.yaml
stevejgordon f1dd3dd
Update based on PR feedback
stevejgordon 4ae73ed
Rename to dotnet and address PR feedback
stevejgordon d08792a
Fix issue templates
stevejgordon 72c1657
Update dotnet attribute registry
stevejgordon 1a27404
Switch to error.type attribute for exceptions
stevejgordon fe47a31
Add brief to gc.heap.generation members
stevejgordon a5da35c
Fix DocumentStatus URL
stevejgordon cdbef6a
Move implementation hints to notes in yaml
stevejgordon 3d14868
Update with proposed renames
stevejgordon 630ee50
Fix YAML
stevejgordon aa4eb33
Fix trailing quote in note in YAML
stevejgordon 1aefc29
PR renaming feedback
stevejgordon 5d63a8f
Add CPU metrics
stevejgordon a4ad895
Fix unit on dotnet.thread_pool.queue.length
stevejgordon dc63af3
Fix typo in metric name
stevejgordon 88fd58c
Clarify memory committed
stevejgordon 90a9356
Update tables and TOC
stevejgordon f8866a1
Apply latest naming suggestions
stevejgordon eab22b2
Add meter name notes, cleanup MD and ordering
stevejgordon c48510f
Update codeowners
stevejgordon 8e90ea0
Update model/metrics/dotnet-metrics.yaml
stevejgordon 8717a40
Add display name and regen tables
stevejgordon b4b98c0
Update model/metrics/dotnet-metrics.yaml
stevejgordon 085e331
Update tables
stevejgordon fbd75f2
Update attribute registry
stevejgordon 6b7a0ed
Clarify gc collections note
stevejgordon 47ed007
Merge branch 'main' into dotnet-runtime-metrics
d104216
Apply suggestions from code review
6dcfd10
regenrate table
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: new_component | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: dotnet | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Adds experimental metrics for the .NET Common Language Runtime (CLR)." | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [956] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,6 +39,7 @@ body: | |
| - area:device | ||
| - area:disk | ||
| - area:dns | ||
| - area:dotnet | ||
| - area:error | ||
| - area:event | ||
| - area:exception | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,6 +31,7 @@ body: | |
| - area:device | ||
| - area:disk | ||
| - area:dns | ||
| - area:dotnet | ||
| - area:error | ||
| - area:event | ||
| - area:exception | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,6 +40,7 @@ body: | |
| - area:device | ||
| - area:disk | ||
| - area:dns | ||
| - area:dotnet | ||
| - area:error | ||
| - area:event | ||
| - area:exception | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <!--- Hugo front matter used to generate the website version of this page: | ||
| ---> | ||
|
|
||
| <!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
| <!-- see templates/registry/markdown/attribute_namespace.md.j2 --> | ||
|
|
||
| # Dotnet | ||
|
|
||
| ## .NET Attributes | ||
|
|
||
| This document defines .NET related attributes. | ||
|
|
||
| | Attribute | Type | Description | Examples | Stability | | ||
| | --------------------------- | ------ | ------------------------------------------------------ | ---------------------- | ---------------------------------------------------------------- | | ||
| | `dotnet.gc.heap.generation` | string | Name of the garbage collector managed heap generation. | `gen0`; `gen1`; `gen2` |  | | ||
|
|
||
| `dotnet.gc.heap.generation` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. | ||
|
|
||
| | Value | Description | Stability | | ||
| | ------ | ------------------ | ---------------------------------------------------------------- | | ||
| | `gen0` | Generation 0 |  | | ||
| | `gen1` | Generation 1 |  | | ||
| | `gen2` | Generation 2 |  | | ||
| | `loh` | Large Object Heap |  | | ||
| | `poh` | Pinned Object Heap |  | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.