-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GraphGL semconv out of DB folder #730
Comments
It seems there were no discussions on this in open-telemetry/opentelemetry-specification#2456 when it was introduced. @laurit do you happen to remember if there was a specific reason to add a new attribute? |
Also, graphql does not extend |
db.graphql.operation.name
-> db.operation
graphql.operation.name
-> db.operation
I believe I used the attribute names from the nodjs graphql instrumentation.
As far as I remember treating graphql as, or as a subset, of db was not considered during the review. |
Well, I guess there we have some breaking changes :D |
it's not clear to me the criteria for GraphQL being grouped under databases? |
Honest question, why does it need to be under |
If we don't consider GraphQL to be a database, it would totally be fine to not add and stop listing it under DB semconv
Both options work for me. |
Oh, I didn't know its location. Thanks. I agree on moving it. IMHO, it should have its own folder, since it doesn't seem to fit into any other existing one. |
graphql.operation.name
-> db.operation
Should be covered by
db.operation
.The text was updated successfully, but these errors were encountered: