New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommendation that attribute keys should be lowercase #586

Closed

arminru opened this issue Dec 6, 2023 · 1 comment · Fixed by #788

Assignees

Member

arminru commented Dec 6, 2023 •

edited

Loading

In open-telemetry/opentelemetry-specification#3782 it was brought up that the (de-facto) case sensitivity of attribute keys is not documented. A clarification on that will likely be added to the spec (open-telemetry/opentelemetry-specification#3784).

In our attribute naming guidelines at https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/attribute-naming.md#attribute-naming, we do not cover casing. It is implied to some extent since all examples are lowercase and so are all currently defined keys in semantic conventions, but we might want to call that out explicitly.

github-actions bot assigned AlexanderWert

github-actions bot added the Stale label

joaopgrassi removed the Stale label

joaopgrassi mentioned this issue

[chore] Add recommendation for lowercase attribute names #788

Merged

3 tasks

Member

joaopgrassi commented Feb 29, 2024

I opened a PR for it #788

joaopgrassi closed this as completed in #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment