Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute naming checks #1068

Closed
lmolkova opened this issue May 23, 2024 · 0 comments · Fixed by #1209
Closed

Add attribute naming checks #1068

lmolkova opened this issue May 23, 2024 · 0 comments · Fixed by #1209
Assignees
Labels
area:other bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

lmolkova commented May 23, 2024

According to attribute naming:

- Names SHOULD NOT coincide with namespaces. For example if
`service.instance.id` is an attribute name then it is no longer valid to have
an attribute named `service.instance` because `service.instance` is already a
namespace. Because of this rule be careful when choosing names: every existing
name prohibits existence of an equally named namespace in the future, and vice
versa: any existing namespace prohibits existence of an equally named
attribute key in the future.

we SHOULD NOT allow adding attributes that would collide with namespaces (e.g. in presence of log.iostream attribute, we should not allow adding log.iostream.something_else).

But we don't have an automated check for it

Steps to Reproduce (if any)

#1067

Expected Result

There should be a check preventing adding an attribute like log.iostream.something_else in presence of existing attribute log.iostream or vice versa

Actual Result

Semconv checks are passed and attribute can be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:other bug Something isn't working
Projects
Archived in project
3 participants