From 455b1ff0517bb00fbdac83f0dd3e58564e9c2bdb Mon Sep 17 00:00:00 2001 From: Joshua MacDonald Date: Tue, 28 May 2024 15:41:57 -0700 Subject: [PATCH] [otel-arrow/exporter] Remove call to SetSpanSizeAttributes; make Count call unconditional --- .../otelarrowexporter/internal/arrow/stream.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/collector/exporter/otelarrowexporter/internal/arrow/stream.go b/collector/exporter/otelarrowexporter/internal/arrow/stream.go index b6717641d9..a5d97e53ee 100644 --- a/collector/exporter/otelarrowexporter/internal/arrow/stream.go +++ b/collector/exporter/otelarrowexporter/internal/arrow/stream.go @@ -351,13 +351,10 @@ func (s *Stream) encodeAndSend(wri writeItem, hdrsBuf *bytes.Buffer, hdrsEnc *hp // unreliable for arrow transport, so we instrument it // directly here. Only the primary direction of transport // is instrumented this way. - if wri.uncompSize != 0 { - var sized netstats.SizesStruct - sized.Method = s.method - sized.Length = int64(wri.uncompSize) - s.netReporter.CountSend(ctx, sized) - s.netReporter.SetSpanSizeAttributes(ctx, sized) - } + var sized netstats.SizesStruct + sized.Method = s.method + sized.Length = int64(wri.uncompSize) + s.netReporter.CountSend(ctx, sized) if err := s.client.Send(batch); err != nil { // The error will be sent to errCh during cleanup for this stream.