-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General SDK Configuration #4059
Comments
Good point! We may need to do an audit and make sure the docs page is not promising something not implemented by the language sdks! |
Huh, TIL. I would have figured at least |
Maybe its worth exploring is spec is willing to make some env variables mandatory? I am not sure what was the reason it was optional in the spec. (That'll, unfortunately, open up other heated discussion about priority - code or env-var who wins! From my own experience, languages vary in this regard) |
From a docs perspective the first thing to do is indeed adding a disclaimer that says what is state of the spec right now, but from an overall perspective I agree that providing some more consistency here would be very end-user friendly. |
@willie would you be willing to provide a PR with such a disclaimer? |
Resolved by #4099 |
Apparently, environmental variables are optional, but the SDK documentation does not indicate this.
For example, the C++ SDK does not implement
OTEL_SERVICE_NAME
. open-telemetry/opentelemetry-cpp#2559The text was updated successfully, but these errors were encountered: