Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Use find_package insead of adding include directories 1 by 1 #3974

Closed
svrnm opened this issue Feb 9, 2024 · 3 comments · Fixed by #4309
Closed

[C++] Use find_package insead of adding include directories 1 by 1 #3974

svrnm opened this issue Feb 9, 2024 · 3 comments · Fixed by #4309
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed sig:cpp

Comments

@svrnm
Copy link
Member

svrnm commented Feb 9, 2024

via #3423 (comment) from @ThomsonTan

Could here use find_package(opentelemetry-cpp CONFIG) instead of adding include directories 1 by 1?

cc @Akhaled19

@svrnm svrnm added bug Something isn't working enhancement New feature or request sig:cpp and removed bug Something isn't working labels Feb 9, 2024
@svrnm svrnm added help wanted Extra attention is needed good first issue Good for newcomers and removed stale labels Apr 16, 2024
@svrnm
Copy link
Member Author

svrnm commented Apr 16, 2024

Tagged this as good first issue and help wanted. Note that this is only a good first issue if someone knows C++ well enough to tackle it (since this is required, not so much being able to work with our docs)

@ricardoamaro
Copy link
Contributor

Giving a try on this one

@ricardoamaro
Copy link
Contributor

Here is my try #4309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed sig:cpp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants