Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how to handle instrument name conflict #3626

Merged
merged 19 commits into from
Aug 9, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 26, 2023

  • Refactor the "Duplicate instrument registration" section
  • Clarify how to handle when instrument names differ by only their casing:
    1. Return the first-seen instrument name for all conflicting instrument names
    2. Log a warning

Resolves #3539

cc @jack-berg @ocelotl @dyladan

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arminru arminru added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Aug 1, 2023
@MrAlias MrAlias mentioned this pull request Aug 7, 2023
@carlosalberto
Copy link
Contributor

carlosalberto commented Aug 7, 2023

@MrAlias asked in our 1.24.0 release whether this can be included too. Does anybody oppose it? Otherwise, let's merge this PR prior to the August release.

@carlosalberto carlosalberto merged commit 2038b78 into open-telemetry:main Aug 9, 2023
@MrAlias MrAlias deleted the inst-name-conflict branch August 9, 2023 15:50
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
- Refactor the "Duplicate instrument registration" section
- Clarify how to handle when instrument names differ by only their
casing:
1. Return the first-seen instrument name for all conflicting instrument
names
  2. Log a warning

Resolves open-telemetry#3539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

How to handle case-insensitive instrument name collisions in metric SDK
10 participants