-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify how to handle instrument name conflict #3626
Merged
carlosalberto
merged 19 commits into
open-telemetry:main
from
MrAlias:inst-name-conflict
Aug 9, 2023
Merged
Specify how to handle instrument name conflict #3626
carlosalberto
merged 19 commits into
open-telemetry:main
from
MrAlias:inst-name-conflict
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
approved these changes
Jul 27, 2023
Co-authored-by: Robert Pająk <[email protected]>
jack-berg
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
arminru
added
area:sdk
Related to the SDK
spec:metrics
Related to the specification/metrics directory
labels
Aug 1, 2023
arminru
reviewed
Aug 1, 2023
jsuereth
approved these changes
Aug 1, 2023
reyang
approved these changes
Aug 1, 2023
jmacd
approved these changes
Aug 1, 2023
arminru
reviewed
Aug 1, 2023
Merged
@MrAlias asked in our 1.24.0 release whether this can be included too. Does anybody oppose it? Otherwise, let's merge this PR prior to the August release. |
dashpole
approved these changes
Aug 8, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
- Refactor the "Duplicate instrument registration" section - Clarify how to handle when instrument names differ by only their casing: 1. Return the first-seen instrument name for all conflicting instrument names 2. Log a warning Resolves open-telemetry#3539
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3539
cc @jack-berg @ocelotl @dyladan