Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that MetricReader has one-to-one mapping to MeterProvider #2406

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Clarify that MetricReader has one-to-one mapping to MeterProvider #2406

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efb5329
Clarify that MetricReader has one-to-one mapping to MeterProvider
reyang Mar 7, 2022
e7f0bbb
changelog
reyang Mar 7, 2022
cf74b98
Update specification/metrics/sdk.md
reyang Mar 8, 2022
eced8f3
Merge branch 'main' into reyang/metrics-sdk-reader-clarification
reyang Mar 11, 2022
381f49b
Merge branch 'main' into reyang/metrics-sdk-reader-clarification
reyang Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ release.
([#2317](https://github.com/open-telemetry/opentelemetry-specification/pull/2317)).
- Clarify that expectations for user callback behavior are documentation REQUIREMENTs.
([#2361](https://github.com/open-telemetry/opentelemetry-specification/pull/2361)).
- Clarify that MetricReader has one-to-one mapping to MeterProvider.
([#2406](https://github.com/open-telemetry/opentelemetry-specification/pull/2406)).

### Logs

Expand Down
3 changes: 3 additions & 0 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,9 @@ that SDK will update the time range - e.g. from (T<sub>n</sub>, T<sub>n+1</sub>]
to (T<sub>n+1</sub>, T<sub>n+2</sub>] - **ONLY** for this particular
`MetricReader` instance.

The SDK MUST NOT allow a `MetricReader` instance to be registered on more than
one `MeterProvider` instance.
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved

```text
+-----------------+ +--------------+
| | Metrics... | |
Expand Down