-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify what does wildcard mean in the Metrics SDK View #2325
Clarify what does wildcard mean in the Metrics SDK View #2325
Conversation
Co-authored-by: Diego Hurtado <[email protected]>
Hey, don't we need also an escape character to be defined here? What if a name includes |
Instrument names have restrictions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good this is how JS was already implemented
If a language provides a shell Otherwise, we should give an algorithm for implementing this matcher. 😁 |
Is this sufficient? $input = "foo*bar?"
$input =~ s/\?/./g
$input =~ s/\*/.*/g
matchRe = /^$input$/ # /^foo.*bar.$/ |
…ry#2325) * Clarify what does wildcard mean in the Metrics SDK View * changelog * Update specification/metrics/sdk.md Co-authored-by: Diego Hurtado <[email protected]> * feedback * fix url Co-authored-by: Diego Hurtado <[email protected]> Co-authored-by: Joshua MacDonald <[email protected]>
Discussed in the 2/28/2022 Specification SIG Meeting.