Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark relevant portions of Metrics DataModel stable #1728

Merged
merged 8 commits into from
Jun 7, 2021

Conversation

jsuereth
Copy link
Contributor

  • All components outlining what data is provided and its meaning is marked as stable.
  • Sections providing guidance and support for handling of data marked as experimental.

@jsuereth jsuereth marked this pull request as ready for review May 27, 2021 19:03
@jsuereth jsuereth requested review from a team May 27, 2021 19:03
specification/metrics/datamodel.md Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
@arminru arminru added area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory labels May 28, 2021
@jsuereth jsuereth mentioned this pull request Jun 3, 2021
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jsuereth jsuereth mentioned this pull request Jun 7, 2021
@carlosalberto
Copy link
Contributor

@open-telemetry/specs-metrics-approvers Is this ready to go in today's (1.4.) Specification release?

(thanks for the question @jsuereth!)

@carlosalberto
Copy link
Contributor

Talked to @reyang and this is ready to go in 1.4 as well.

@carlosalberto carlosalberto merged commit e7d9642 into open-telemetry:main Jun 7, 2021
@jsuereth jsuereth deleted the wip-datamodel-stability branch June 7, 2021 22:01
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Mark sections of datamodel stable.

* Generated ToC

* Clean up MUST and SHOULD in the document.

* adjust for bug in markdown-toc

* Mark protocol as stable.

Co-authored-by: Carlos Alberto Cortez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants