-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark relevant portions of Metrics DataModel stable #1728
Merged
carlosalberto
merged 8 commits into
open-telemetry:main
from
jsuereth:wip-datamodel-stability
Jun 7, 2021
Merged
Mark relevant portions of Metrics DataModel stable #1728
carlosalberto
merged 8 commits into
open-telemetry:main
from
jsuereth:wip-datamodel-stability
Jun 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsuereth
commented
May 27, 2021
- All components outlining what data is provided and its meaning is marked as stable.
- Sections providing guidance and support for handling of data marked as experimental.
jmacd
approved these changes
May 28, 2021
arminru
reviewed
May 28, 2021
arminru
added
area:data-model
For issues related to data model
spec:metrics
Related to the specification/metrics directory
labels
May 28, 2021
Merged
reyang
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
bogdandrutu
approved these changes
Jun 7, 2021
Merged
@open-telemetry/specs-metrics-approvers Is this ready to go in today's (1.4.) Specification release? (thanks for the question @jsuereth!) |
Aneurysm9
approved these changes
Jun 7, 2021
Talked to @reyang and this is ready to go in 1.4 as well. |
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Mark sections of datamodel stable. * Generated ToC * Clean up MUST and SHOULD in the document. * adjust for bug in markdown-toc * Mark protocol as stable. Co-authored-by: Carlos Alberto Cortez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:data-model
For issues related to data model
spec:metrics
Related to the specification/metrics directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.