-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in OpenCensus, OpenTracing specs #17
Merged
SergeyKanzhelev
merged 5 commits into
open-telemetry:master
from
c24t:import-opencensus-specs
May 21, 2019
Merged
Merge in OpenCensus, OpenTracing specs #17
SergeyKanzhelev
merged 5 commits into
open-telemetry:master
from
c24t:import-opencensus-specs
May 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still TODO:
|
I'd suggest to create work-in-progress folder for specs the same way we did for semantics model. And copy files when complete. This way we can merge this PR as is and iteratively improve in smaller PRs. |
SergeyKanzhelev
approved these changes
May 21, 2019
I'll merge as this goes to work-in-progress folder. Similar to what we did with #14. More reviewers would be needed for documents going to non-WIP folders |
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
* Setup basic ci * Add empty README * Fix script path * Fill out README. * Typo. * Add missing script name. * Remove unnecessary packages * Use fastbuild. * Fix typo. Co-authored-by: easy <[email protected]>
lmolkova
added a commit
to lmolkova/opentelemetry-specification
that referenced
this pull request
Nov 4, 2021
Co-authored-by: Joao Grassi <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 30, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 30, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Copy OC specs into specification dir * Copy OT spec into specification/README.md * Remove work-in-progress files * Move specification/ into work_in_progress/
carlosalberto
pushed a commit
that referenced
this pull request
Nov 8, 2024
carlosalberto
pushed a commit
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #13.
This is a WIP PR to reconcile the opencensus and opentracing specs. The goal is to describe the java client as it stands now, without prescribing any new behaviors or language-specific implementation details.
This is WIP in that the structure and the content needs to change significantly before this is merged. I copied both specs (OT into
specification/README.md
and OC intospecification/
) to make it easy to comment on the existing specs to point out what behavior has changed. Hopefully this will help us collect these changes to describe in another doc for #12.Open questions
Should the spec describe the API only, or should it include required SDK components as in #6?
Should the spec describe context propagation? Some options are:
Context
, python'scontextvars
, etc. hereShould the spec include the protos, a prose description of the data structures the protos represent, or neither?
Should
Noop
/Default
classes be considered part of the API, SDK, or left out as an implementation detail?Should the spec describe exporting to opencensus and opentracing? As I understand it both libraries will eventually depend on opentelemetry, but it may be helpful to client authors to describe the OC/OT shims in the meantime.
cc @bogdandrutu, @iredelmeier