Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detail about StartTimeUnixNano, gaps and resets #1646

Merged
merged 6 commits into from
May 17, 2021
Merged

Add detail about StartTimeUnixNano, gaps and resets #1646

merged 6 commits into from
May 17, 2021
+87 −13

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Apr 26, 2021

Changes

Adds detail about when to use StartTimeUnixNano and handling of unknown start-time resets.

Related issues:
open-telemetry/opentelemetry-proto#289
open-telemetry/opentelemetry-proto#292

@jmacd jmacd marked this pull request as ready for review April 26, 2021 20:20
@jmacd jmacd requested review from a team April 26, 2021 20:20
reyang
reyang approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmacd jmacd mentioned this pull request Apr 27, 2021
Closed
jsuereth
jsuereth reviewed Apr 28, 2021
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a bit of wordsmithing nits.

specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
@jmacd jmacd mentioned this pull request Apr 29, 2021
Merged
@jsuereth jsuereth added area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory labels May 4, 2021
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 12, 2021
@jmacd jmacd merged commit 2ec40f3 into open-telemetry:main May 17, 2021
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@jmacd
Add detail about StartTimeUnixNano, gaps and resets (open-telemetry#1646
a651711 
)

* Add detail about StartTimeUnixNano, gaps and resets

* Changelog

* Edit

* Call out special case of reaggregation

* Apply feedback from reviewers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victlu victlu victlu approved these changes

@reyang reyang reyang approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmacd @jsuereth @reyang @victlu @carlosalberto