-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default global propagators #428
Comments
How has the situation changed here with OTEP 66? Some default HttpTextFormat or equivalent had to exist even before. |
I know a few languages already had |
In JS the TraceContext propagator is in the SDK package not the API package. As far as I'm aware, this is the case for most of the SIGs. Additionally, in JS context management is no-op by default, which means even if the propagator extracted a value, it would be added to a no-op context and dropped. At least in JS, we cannot have a default context manager that works in both web and nodejs. We could have platform-specific defaults if required, but this is not the way it currently works. |
Sooo. What's the state of this issue? Someone needs to own it. |
I will own it. Will dig what's the state of this for each SIG and will re-start the discussion. |
As per #208 (comment) I would suggest we stay with no-op. |
(I'm starting to feel having no propagators registered by default is the way to go - agents and similar layers can be the ones setting them as needed) |
I think it should be easy (single function call or right package in classpath etc) to configure OpenTelemetry to act as transparent proxy, but it should not be the default. |
A lot of the work to determine the state of each SIG has already been done on this issue. |
My 2c: OTel should have sensible defaults so that it would do sensible things out of the box. Without requiring any configuration. Like using OTLP exporter to localhost:$defaultPort. And using W3C TraceContext propagator. Etc. Not forcing users to make a lot movements to get something working... |
I think we have to discuss separately:
|
Without SDK and without auto-instrumentation - no-op, agreed. As soon as we have SDK or auto-instrumentation we should propagate context even if we don't do anything ourselves in this process. We just should decide which wire format to use. My vote goes to W3C TraceContext. |
@carlosalberto can we get a status update on this? |
@jkwatson hey, thanks for asking. I have a draft proposal locally that I will send as a PR tomorrow (and FYI, in the proposal we go propagatorless by default). |
Now that OTEP 66 was merged, we need to decide what the default global propagators need to be, either no-op or something meaningful (like
TraceContext
/CorrelationContext
).See: #208
The text was updated successfully, but these errors were encountered: