Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify scalar value types in Logs Data Model #3836

Closed
pellared opened this issue Jan 19, 2024 · 1 comment · Fixed by #3854
Closed

Clarify scalar value types in Logs Data Model #3836

pellared opened this issue Jan 19, 2024 · 1 comment · Fixed by #3854
Assignees
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:logs Related to the specification/logs directory

Comments

@pellared
Copy link
Member

pellared commented Jan 19, 2024

The Logs Data Model is sparing describing the scalar values and it misses more information about the types.

See: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#type-any

I think that the specification should be precise similarly to: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/README.md#attribute.

Some logging libraries make it possible to pass a uint64 attribute. However, it looks that it is not really possible to correctly pass such value via OTLP. But other exporters may able to handle such value so maybe uint64 should be supported as well?

CC @open-telemetry/specs-logs-approvers

Related PR: pellared/opentelemetry-go#7

@pellared
Copy link
Member Author

CC @lalitb

@reyang reyang added the [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:logs Related to the specification/logs directory
Projects
None yet
3 participants