Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default histogram bucket bounds are too big for seconds durations #3525

Closed
JamesNK opened this issue Jun 1, 2023 · 2 comments
Closed

Default histogram bucket bounds are too big for seconds durations #3525

JamesNK opened this issue Jun 1, 2023 · 2 comments
Assignees
Labels
spec:metrics Related to the specification/metrics directory

Comments

@JamesNK
Copy link

JamesNK commented Jun 1, 2023

#2770 changed histogram buckets to match Prometheus SDK values. However, the OTel values are 1000 times bigger. That made sense when OTel semantic conventions recommended milliseconds for durations compared to Prometheus's seconds.

OTel recently decided to change its semantic conventions to use seconds for durations to be in line with Prometheus. The side effect of not changing the bucket bounds default at the same time is now the buckets are too large. The smallest bucket captures everything that takes 0-5 seconds instead of 0-5 milliseconds.

I guess most histograms measure short durations, e.g. less than 10 seconds. With the current defaults, those histograms will need to override the bucket bounds because they're not appropriate. If most people need to change the defaults then maybe they aren't the right defaults.

Should the bucket sizes reduce by 1000?

@JamesNK JamesNK added the spec:metrics Related to the specification/metrics directory label Jun 1, 2023
@JamesNK
Copy link
Author

JamesNK commented Jun 1, 2023

I just noticed there is an open PR for this: #3509

@reyang
Copy link
Member

reyang commented May 29, 2024

Discussed during May 29th, 2024 TC Metting, here is the decision:

  1. We do not intend to change the default bucket bounds.
  2. Instrumentation authors are advised to use advisory parameters.
  3. In addition, semantic conventions have specific guidance on what buckets should be used while providing advisory parameters. https://github.com/search?q=repo%3Aopen-telemetry%2Fsemantic-conventions+%22advisory-parameters%22&type=code

@reyang reyang closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
@reyang reyang removed the triage:deciding:tc-inbox Needs attention from the TC in order to move forward label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

4 participants