Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should HTTP semantic conventions say anything about nested spans? #3281

Closed
trask opened this issue Mar 3, 2023 · 3 comments
Closed

Should HTTP semantic conventions say anything about nested spans? #3281

trask opened this issue Mar 3, 2023 · 3 comments
Assignees
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Mar 3, 2023

For example:

  • Should nesting of HTTP server spans not be allowed?

  • Should nesting of HTTP client spans be allowed?

@trask trask added the spec:trace Related to the specification/trace directory label Mar 3, 2023
@trask trask added area:semantic-conventions Related to semantic conventions semconv:HTTP labels Mar 3, 2023
@trask trask moved this to Blocker for stability in Spec: HTTP Semantic Conventions Mar 3, 2023
@trask trask assigned trask and unassigned reyang Mar 3, 2023
@scheler
Copy link
Contributor

scheler commented Mar 5, 2023

Just asking out of curiousity. What is the guidance on the span kind proxies should use for the span they emit, if they emit only one span? Or are they required to emit 2 spans, one server and one client?

@trask
Copy link
Member Author

trask commented Mar 6, 2023

Discussed in today's semconv meeting, and closing because the issue primarily because nesting is more of a "cross-instrumentation" issue which should be handled at a higher level (specifically see open-telemetry/oteps#172)

@trask trask closed this as completed Mar 6, 2023
@github-project-automation github-project-automation bot moved this from Blocker for stability to Done in Spec: HTTP Semantic Conventions Mar 6, 2023
@trask
Copy link
Member Author

trask commented Mar 6, 2023

Just asking out of curiousity. What is the guidance on the span kind proxies should use for the span they emit, if they emit only one span? Or are they required to emit 2 spans, one server and one client?

hey @scheler, I don't think there's any specific guidance yet for this case, I'd suggest emitting 2 spans myself, as that would fit the current conventions (and probably the majority of backends).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:trace Related to the specification/trace directory
Projects
Development

No branches or pull requests

3 participants