Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid openshift platform name in semconv 1.16.0 #3090

Closed
frzifus opened this issue Jan 10, 2023 · 3 comments · Fixed by #3095
Closed

Invalid openshift platform name in semconv 1.16.0 #3090

frzifus opened this issue Jan 10, 2023 · 3 comments · Fixed by #3095
Assignees
Labels
spec:resource Related to the specification/resource directory

Comments

@frzifus
Copy link
Member

frzifus commented Jan 10, 2023

What are you trying to achieve?

I would like to identify openshift on in google cloud.

What did you expect to see?

A platform attribute with the value gcp_openshift.

Additional context.

Seems that the attribute wasnt well named in #2985 According to the documentation it should be named gcp instead of google_cloud.

The prefix of the service SHOULD match the one specified in cloud.provider.

Like here:

brief: Google Cloud Kubernetes Engine (GKE)
- id: gcp_cloud_functions
value: 'gcp_cloud_functions'
brief: Google Cloud Functions (GCF)
- id: gcp_app_engine
value: 'gcp_app_engine'
brief: Google Cloud App Engine (GAE)
- id: google_cloud_openshift
value: 'google_cloud_openshift'
brief: Red Hat OpenShift on Google Cloud

But it does not.

@frzifus frzifus added the spec:resource Related to the specification/resource directory label Jan 10, 2023
@joaopgrassi
Copy link
Member

joaopgrassi commented Jan 10, 2023

Good find, we missed that during the initial PR. Given that this semconv is still experimental, I think it should be OK to fix it, even though it was released. Not sure if it's possible/required that we do something with it in the schema file given it's enum values.

@frzifus
Copy link
Member Author

frzifus commented Jan 10, 2023

Ok just to be clear, instead of adding a additional gcp_openshift entry and releasing 1.16.1 - we fix it inline and regenerate semconv 1.16.0 in the collector and go repo?

@joaopgrassi
Copy link
Member

I don't think we can re-generate 1.16, it will be in the next release with the correct value. But let's see with others have to say about the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:resource Related to the specification/resource directory
Projects
None yet
3 participants