Skip to content

Are rpc.request.metadata and rpc.response.metadata gRPC specific? #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trask opened this issue Nov 10, 2022 · 1 comment · Fixed by #2981
Closed

Are rpc.request.metadata and rpc.response.metadata gRPC specific? #2935

trask opened this issue Nov 10, 2022 · 1 comment · Fixed by #2981
Assignees
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory

Comments

@trask
Copy link
Member

trask commented Nov 10, 2022

What are you trying to achieve?

Clarity on whether rpc.request.metadata. and rpc.response.metadata. are generic RPC attributes, or specific to gRPC.

What did you expect to see?

If they are generic RPC attributes, I would not expect them to be under the gRPC section of the RPC semantic attributes.

If they are gRPC specific attributes, I would expect them to be prefixed with rpc.grpc., similar to rpc.grpc.status_code.

@trask trask added the spec:trace Related to the specification/trace directory label Nov 10, 2022
@arminru arminru added the area:semantic-conventions Related to semantic conventions label Nov 14, 2022
@reyang
Copy link
Member

reyang commented Nov 14, 2022

I think these should be gRPC metadata instead of generic metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
4 participants