Add additional attributes for mongo DB spans

[avzis]

What are you trying to achieve?
I want to add to the database semantic conventions additional attributes for mongo DB spans.
The value of adding these fields is to help users get more information from the traces which would allow for easier troubleshooting.

The additional attributes that I want to add are related to operations done on the DB.

For an INSERT request:
Save the value document which holds the value that is inserted.

For a DELETE request:
Save the value criteria which holds the filter criteria that is used to find the item to delete.

For an UPDATE request:
Save the values of filter and update which holds the filter criteria that is used to identify the item that we want to update, and the value to update.

[carlosalberto]

Hey @avzis - was wondering why db.statement is not used here? e.g. it is used for Redis commands such as SET mykey "WuValue" which seems to have all the information you need (applying this to Mongo).

[avzis]

Hey @carlosalberto, thank you for the response.
I tried to check the db.statement value, and from what i've seen it only saves the request name, and not the values.
I will need to check whether this is an issue with the implementation in mongoDB

[carlosalberto]

I think this is indeed a bug in the instrumentation itself, as the Spec requires that db.statement does report the full statement:

SELECT * FROM wuser_table; SET mykey "WuValue"

[trask]

@avzis in case you are using Java, check out https://opentelemetry.io/docs/instrumentation/java/automatic/agent-config/#db-statement-sanitization

[avzis]

opened a bug:
open-telemetry/opentelemetry-python-contrib#1462