Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.flavor should become net.app.protocol.name and net.app.protocol.version #2626

Closed
lmolkova opened this issue Jun 21, 2022 · 3 comments · Fixed by #3272
Closed

http.flavor should become net.app.protocol.name and net.app.protocol.version #2626

lmolkova opened this issue Jun 21, 2022 · 3 comments · Fixed by #3272
Assignees
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide semconv:HTTP spec:trace Related to the specification/trace directory

Comments

@lmolkova
Copy link
Contributor

With #2602 net.app.protocol.name and net.app.protocol.version would be a standard way to describe protocol and http.flavor can be removed.

http.flavor has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used.

Value Description
1.0 HTTP/1.0
1.1 HTTP/1.1
2.0 HTTP/2
3.0 HTTP/3
SPDY SPDY protocol.
QUIC QUIC protocol.

Proposal:

  • remove http.flavor
  • net.app.protocol.name is recommended if it's not HTTP. SPDY and QUIC should go here
  • net.app.protocol.version to contain 1.1, 2.0, etc..
@lmolkova lmolkova added the spec:trace Related to the specification/trace directory label Jun 21, 2022
@Oberon00
Copy link
Member

What do I do if I want to encode the HTTP version used in a grpc call? Probably just a HTTP child span under the grpc span?

@pyohannes
Copy link
Contributor

@Oberon00 Not sure if I interpret the RPC conventions correctly, but it seems to always recommend the creation of the HTTP span, either as child of an RPC span or as "carrier" of RPC attributes.

HTTP calls can generally be represented using just HTTP spans. If they address a particular remote service and method known to the caller, i.e., when it is a remote procedure call transported over HTTP, the rpc.* attributes might be added additionally on that span, or in a separate RPC span that is a parent of the transporting HTTP call.

@rbailey7210
Copy link

Discussed during triage meeting. Item has been deferred. @lmolkova please discuss at the next Instrumentation SIG, and get support on this issue. Depending on responses from SIG, we can decide on whether to move forward.

@reyang reyang added the [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide label Jun 24, 2022
@lmolkova lmolkova moved this to Blockers for HTTP semconv stability in Semantic Conventions + Instrumentation Stability WG Jan 9, 2023
@trask trask assigned lmolkova and unassigned arminru Jan 30, 2023
@trask trask moved this to Blocker for stability in Spec: HTTP Semantic Conventions Jan 31, 2023
@arminru arminru added semconv:HTTP area:semantic-conventions Related to semantic conventions labels Jan 31, 2023
@trask trask assigned trask and unassigned lmolkova Feb 6, 2023
@github-project-automation github-project-automation bot moved this from Blocker for stability to Done in Spec: HTTP Semantic Conventions Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions [label deprecated] triaged-needmoreinfo [label deprecated] The issue is triaged - the OTel community needs more information to decide semconv:HTTP spec:trace Related to the specification/trace directory
Projects
7 participants