-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http.flavor should become net.app.protocol.name and net.app.protocol.version #2626
Comments
What do I do if I want to encode the HTTP version used in a grpc call? Probably just a HTTP child span under the grpc span? |
@Oberon00 Not sure if I interpret the RPC conventions correctly, but it seems to always recommend the creation of the HTTP span, either as child of an RPC span or as "carrier" of RPC attributes.
|
Discussed during triage meeting. Item has been deferred. @lmolkova please discuss at the next Instrumentation SIG, and get support on this issue. Depending on responses from SIG, we can decide on whether to move forward. |
With #2602
net.app.protocol.name
andnet.app.protocol.version
would be a standard way to describe protocol andhttp.flavor
can be removed.1.0
1.1
2.0
3.0
SPDY
QUIC
Proposal:
http.flavor
net.app.protocol.name
is recommended if it's notHTTP
.SPDY
andQUIC
should go herenet.app.protocol.version
to contain1.1
,2.0
, etc..The text was updated successfully, but these errors were encountered: