-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should http.scheme
be renamed to uri.scheme
?
#2489
Comments
This would be the kind of the opposite direction of #2056, wouldn't it? I could imagine renaming to http.url_scheme (or http.uri_scheme) but I don't think there is a real problem with the current name that warrants the disruption caused by renaming (even though it is eased by the convention schema mechanism). |
FYI this is the ECS approach: https://www.elastic.co/guide/en/ecs/current/ecs-http.html#ecs-http Use the url field set to store the url of the request. |
if we rename and (maybe) rename |
I think this is where we should borrow/learn from ECS, and maybe @AlexanderWert can help us a lot. I will give an example which shows how we end up with if we call it http.url:
|
|
To provide some input from the ECS perspective to this: Being more explicit about all the URL-related aspects and group them under a common namespace would allow to address the examples mentioned here and would also address #2056 So basically:
Also, is it necessary to have different attributes for |
let's move this conversation over to #3163 if no objections |
Strictly speaking
scheme
is not an HTTP concept.https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
The text was updated successfully, but these errors were encountered: