Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling: Introduce decision/flag to not propagate a span. #1663

Open
Oberon00 opened this issue Apr 30, 2021 · 0 comments
Open

Sampling: Introduce decision/flag to not propagate a span. #1663

Oberon00 opened this issue Apr 30, 2021 · 0 comments
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:trace Related to the specification/trace directory

Comments

@Oberon00
Copy link
Member

An idea that I had for #1653 (comment): With the current sampling decisions, you cannot suppress propagation of a Span. You can only influence the sampled flag on the traceflags. In some situations it might be desired to not propagate the span at all cross-process, i.e. cause inject(context) to be a no-op (for the Span part of the context).

This could be added as a new sampling decision that is otherwise equivalent to DROP, or it could be added as an additional boolean flag orthogonal to the current sampling decisions to also allow e.g. RECORDING spans that are only propagated in-process (could be used in combination with the URL which might be available to samplers to not propagate span contexts to external services).

@Oberon00 Oberon00 added the spec:trace Related to the specification/trace directory label Apr 30, 2021
@Oberon00 Oberon00 added the area:sampling Related to trace sampling label Apr 30, 2021
@reyang reyang added area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sampling Related to trace sampling area:sdk Related to the SDK release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

2 participants