Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Resource.Merge for the empty values case #1357

Open
carlosalberto opened this issue Jan 20, 2021 · 1 comment
Open

Improve Resource.Merge for the empty values case #1357

carlosalberto opened this issue Jan 20, 2021 · 1 comment
Labels
area:sdk Related to the SDK priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory

Comments

@carlosalberto
Copy link
Contributor

carlosalberto commented Jan 20, 2021

Follow up to #1345 (comment)

Consider amending the following Resource.Merge section:

If a key exists on both the old and updating resource, the value of the updating
resource MUST be picked (even if the updated value is empty).

Probably not that important, as Resource.Merge will quite often be called only at application start time (besides being a very cheap operation).

cc @bogdandrutu

@carlosalberto carlosalberto added area:sdk Related to the SDK spec:resource Related to the specification/resource directory priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Jan 20, 2021
@Oberon00
Copy link
Member

I think overriding a value with an empty string can also be a feature. Also, where do we expect these empty strings to come from? Wouldn't it usually be better to tweak the producer to not produce the resource attribute at all instead of an empty string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p3 Lowest priority level release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs spec:resource Related to the specification/resource directory
Projects
None yet
Development

No branches or pull requests

2 participants