Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shutdown() to Metric Exporter interface #1348

Closed
evantorrie opened this issue Jan 15, 2021 · 2 comments
Closed

Add Shutdown() to Metric Exporter interface #1348

evantorrie opened this issue Jan 15, 2021 · 2 comments
Assignees
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory

Comments

@evantorrie
Copy link

evantorrie commented Jan 15, 2021

What are you trying to achieve?

I propose adding a Shutdown() or Stop() method to the Metric Exporter SDK interface.

Currently, the Exporter for metrics in the SDK does not have a Shutdown method, whereas the trace SpanExporter does require it

Additional context.

We have an in-house push-based metrics exporter which queues checkpointed records to an asynchronous batched sender.

In the go implementation, the pusher implementation has a Stop() method, which sends one final checkpoint of records to the metric exporter. However, it has no way to notify the exporter that it is stopping - i.e. that the exporter should also at least flush/shut down itself as well.

It seems somewhat inconsistent that SpanExporters have a Shutdown() method but metrics Exporters do not.

@evantorrie evantorrie added the spec:metrics Related to the specification/metrics directory label Jan 15, 2021
@andrewhsu andrewhsu added area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Jan 22, 2021
@tedsuo
Copy link
Contributor

tedsuo commented Feb 16, 2021

Hi @evantorrie; FYI we're rebooting the metrics API WG. The current SDK spec has been removed from the spec, @reyang Is heading a working group that will add it back in once the prototypes are finished. Assigning this to him so we don't lose the requirement.

@reyang
Copy link
Member

reyang commented Sep 9, 2021

Fixed by #1864.

@reyang reyang closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

4 participants