Skip to content

Commit bc76c97

Browse files
authored
Clarify that metric advice is non-identifying (#3661)
Fixes #3622 The language for resolving conflicts matches the language used for naming conflicts. cc @MrAlias @jack-berg @jmacd
1 parent d4b241f commit bc76c97

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ release.
2121
([#3242](https://github.com/open-telemetry/opentelemetry-specification/pull/3242))
2222
- Promote MetricProducer specification to feature-freeze.
2323
([#3600](https://github.com/open-telemetry/opentelemetry-specification/pull/3600))
24+
- Clarify that advice is non-identifying.
25+
([#3661](https://github.com/open-telemetry/opentelemetry-specification/pull/3661))
2426

2527
### Logs
2628

specification/metrics/api.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ will have the following fields:
190190
* Optional `advice` (**experimental**)
191191

192192
Instruments are associated with the Meter during creation. Instruments
193-
are identified by all of these fields.
193+
are identified by the `name`, `kind`, `unit`, and `description`.
194194

195195
Language-level features such as the distinction between integer and
196196
floating point numbers SHOULD be considered as identifying.

specification/metrics/sdk.md

+5
Original file line numberDiff line numberDiff line change
@@ -856,6 +856,11 @@ When a Meter creates an instrument, it SHOULD validate the instrument advice
856856
parameters. If an advice parameter is not valid, the Meter SHOULD emit an error
857857
notifying the user and proceed as if the parameter was not provided.
858858

859+
If multiple [identical Instruments](api.md#instrument) are created with
860+
different advice parameters, the Meter MUST return an instrument using the
861+
first-seen advice parameters and log an appropriate error as described in
862+
[duplicate instrument registrations](#duplicate-instrument-registration).
863+
859864
## Attribute limits
860865

861866
**Status**: [Stable](../document-status.md)

0 commit comments

Comments
 (0)