Skip to content

Commit

Permalink
[Logs] Remove the in-development isolating log record processor (#4301)
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared authored Dec 6, 2024
1 parent aa4bf33 commit 51cb58c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 22 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ release.
([#4183](https://github.com/open-telemetry/opentelemetry-specification/pull/4183))
- Remove the recommendation to not synchronize access to `LoggerConfig.disabled`.
([#4310](https://github.com/open-telemetry/opentelemetry-specification/pull/4310))
- Remove the in-development isolating log record processor.
([#4301](https://github.com/open-telemetry/opentelemetry-specification/pull/4301))

### Events

Expand Down
23 changes: 1 addition & 22 deletions specification/logs/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
* [Built-in processors](#built-in-processors)
+ [Simple processor](#simple-processor)
+ [Batching processor](#batching-processor)
+ [Isolating processor](#isolating-processor)
- [LogRecordExporter](#logrecordexporter)
* [LogRecordExporter operations](#logrecordexporter-operations)
+ [Export](#export)
Expand Down Expand Up @@ -235,8 +234,7 @@ the following information added to the [LogRecord](data-model.md#log-and-event-r
* [`TraceFlags`](./data-model.md#field-traceflags)

The SDK MAY provide an operation that makes a deep clone of a `ReadWriteLogRecord`.
The operation can be used to implement the [isolating processor](#isolating-processor)
or by asynchronous processors (e.g. [Batching processor](#batching-processor))
The operation can be used by asynchronous processors (e.g. [Batching processor](#batching-processor))
to avoid race conditions on the log record that is not required to be
concurrent safe.

Expand Down Expand Up @@ -383,10 +381,6 @@ make the flush timeout configurable.
The standard OpenTelemetry SDK MUST implement both simple and batch processors,
as described below.

**Status**: [Development](../document-status.md) -
The standard OpenTelemetry SDK SHOULD implement an isolating processor,
as described below.

Other common processing scenarios SHOULD be first considered
for implementation out-of-process
in [OpenTelemetry Collector](../overview.md#collector).
Expand Down Expand Up @@ -426,21 +420,6 @@ to make sure that they are not invoked concurrently.
* `maxExportBatchSize` - the maximum batch size of every export. It must be
smaller or equal to `maxQueueSize`. The default value is `512`.

#### Isolating processor

**Status**: [Development](../document-status.md)

This is an implementation of `LogRecordProcessor` ensuring the log record
passed to `OnEmit` of the configured `processor` does not share mutable data
with subsequent registered processors.
For example, the `OnEmit` implementation of the isolating processor can be
a decorator that makes a deep copy of the log record before passing it to
the configured `processor`.

**Configurable parameters:**

* `processor` - processor to be isolated.

## LogRecordExporter

`LogRecordExporter` defines the interface that protocol-specific exporters must
Expand Down

0 comments on commit 51cb58c

Please sign in to comment.