Skip to content

Commit 378087d

Browse files
committed
Review comments
1 parent b132eec commit 378087d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

semantic_conventions/trace/instrumentation/azure-sdk.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ groups:
66
# common
77
- id: azure
88
brief: 'Describes Azure spans.'
9+
prefix: az
910
attributes:
10-
- id: az.namespace
11+
- id: namespace
1112
required: always
1213
type: string
1314
sampling_relevant: true
@@ -32,12 +33,12 @@ groups:
3233
- id: request_id
3334
type: string
3435
required: always
35-
brief: 'Value of the [x-ms-client-request-id] header (or other request-id header, depending on the service) sent by the client.'
36+
brief: 'Value of the "x-ms-client-request-id" header (or other "*-request-id" header, depending on the service) sent by the client.'
3637
examples: ['eb178587-c05a-418c-a695-ae9466c5303c']
3738
- id: service_request_id
3839
type: string
3940
required: always
40-
brief: 'Value of the [x-ms-request-id] header (or other request-id header, depending on the service) sent by the server in response.'
41+
brief: 'Value of the "x-ms-request-id" header (or other "*-request-id" header, depending on the service) sent by the server in response.'
4142
examples: ['3f828ae5-ecb9-40ab-88d9-db0420af30c6']
4243
- ref: http.method
4344
required: always

specification/trace/semantic_conventions/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ The following library-specific semantic conventions are defined:
2727

2828
* [AWS Lambda](instrumentation/aws-lambda.md): For AWS Lambda spans.
2929
* [AWS SDK](instrumentation/aws-sdk.md): For AWS SDK spans.
30+
* [Azure SDK](instrumentation/azure-sdk.md): For Azure SDK spans.
3031

3132
Apart from semantic conventions for traces and [metrics](../../metrics/semantic_conventions/README.md),
3233
OpenTelemetry also defines the concept of overarching [Resources](../../resource/sdk.md) with their own

specification/trace/semantic_conventions/instrumentation/azure-sdk.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,13 @@ Azure SDKs create a span for public API call (that involves communication with A
4242

4343
## HTTP Client
4444

45-
Azure SDK implements a valid subset of [OpenTelemetry HTTP conventions v1.8.0](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.8.0/specification/trace/semantic_conventions/http.md) and create a span per HTTP call (try).
45+
Azure SDK implements a valid subset of [OpenTelemetry HTTP conventions v1.8.0](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.8.0/specification/trace/semantic_conventions/http.md) and create a span per HTTP call (attempt).
4646

4747
<!-- semconv azure.sdk.http -->
4848
| Attribute | Type | Description | Examples | Required |
4949
|---|---|---|---|---|
50-
| `request_id` | string | Value of the [x-ms-client-request-id] header (or other request-id header, depending on the service) sent by the client. | `eb178587-c05a-418c-a695-ae9466c5303c` | Yes |
51-
| `service_request_id` | string | Value of the [x-ms-request-id] header (or other request-id header, depending on the service) sent by the server in response. | `3f828ae5-ecb9-40ab-88d9-db0420af30c6` | Yes |
50+
| `request_id` | string | Value of the "x-ms-client-request-id" header (or other "*-request-id" header, depending on the service) sent by the client. | `eb178587-c05a-418c-a695-ae9466c5303c` | Yes |
51+
| `service_request_id` | string | Value of the "x-ms-request-id" header (or other "*-request-id" header, depending on the service) sent by the server in response. | `3f828ae5-ecb9-40ab-88d9-db0420af30c6` | Yes |
5252
| [`http.method`](../http.md) | string | HTTP request method. | `GET`; `POST`; `HEAD` | Yes |
5353
| [`http.status_code`](../http.md) | int | [HTTP response status code](https://tools.ietf.org/html/rfc7231#section-6). | `200` | Yes |
5454
| [`http.url`](../http.md) | string | Full HTTP request URL in the form `scheme://host[:port]/path?query[#fragment]`. Usually the fragment is not transmitted over HTTP, but if it is known, it should be included nevertheless. [1] | `https://www.foo.bar/search?q=OpenTelemetry#SemConv` | Yes |

0 commit comments

Comments
 (0)