-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry::logs::AnyValue is missing a None variant #1253
Comments
Makes sense -- are you able to submit a PR? Seems like a straightforward addition. |
I can probably submit a PR within next week. Feel free to ping me again if it hasn't happened by then. |
Is there any reason why both |
As per the log data model - the attribute value can be an array of |
Ok, this also answers the next question I had, which is whether I should add
|
Is this related? open-telemetry/opentelemetry-specification#3826 |
I think it is related to this one: open-telemetry/opentelemetry-specification#3853 |
@lalitb Can you check if this is required for stabilizing Logs? |
According to https://opentelemetry.io/docs/specs/otel/common/attribute-type-mapping/:
This is currently unrepresentable with
opentelemetry::logs::AnyValue
, I suggest adding a newNone
variant and serializing that accordingly.The text was updated successfully, but these errors were encountered: