Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial success responses from OTLP export services #1361

Open
jmacd opened this issue Aug 19, 2022 · 1 comment
Open

Handle partial success responses from OTLP export services #1361

jmacd opened this issue Aug 19, 2022 · 1 comment
Labels
bug Something isn't working keep spec-compliance Required for OpenTelemetry spec compliance

Comments

@jmacd
Copy link

jmacd commented Aug 19, 2022

Problem Statement

Following the specification change to add partial success responses, each OTel SDK is encouraged to handle the resulting error message string in an appropriate way, considering existing norms. This requires OTLP v0.19.

Proposed Solution

For each of the Export*ServiceRequest methods used by OTLP Trace and Metrics exporters, construct an error and call the appropriate handler with the error message string and the number of spans/points(/logs) dropped. Future OTel specifications may call for optional treatment of the number of dropped items, but presently that is just additional information to include in the handled error.

Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Mar 11, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 11, 2024
@arielvalentin arielvalentin reopened this Apr 11, 2024
@arielvalentin arielvalentin added keep and removed stale labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keep spec-compliance Required for OpenTelemetry spec compliance
Projects
None yet
Development

No branches or pull requests

3 participants