[WIP] user-facing Logs API that includes events #4213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
public-logs-api-events
branch
from
38acfc3 to
87c2b08
Compare
xrmx
reviewed
Dec 9, 2024
| self.body = body # type: ignore | ||
| self.attributes = attributes | ||
|
|
||
|
|
||
| class Logger(ABC): | ||
| """Handles emitting events and logs via `LogRecord`.""" |
There was a problem hiding this comment.
If this means taking LogRecord it's not the case anymore
| @abstractmethod | ||
| def emit( | ||
| self, | ||
| name: str = None, |
There was a problem hiding this comment.
Is the spec missing the name parameter
https://opentelemetry.io/docs/specs/otel/logs/api/#emit-a-logrecord ? BTW in the sdk you are using event_name
There was a problem hiding this comment.
it's just got merged - open-telemetry/opentelemetry-specification#4320 will be released soon
BTW in the sdk you are using event_name
Good catch!
lmolkova
force-pushed
the
public-logs-api-events
branch
from
23b1945 to
3c09ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves emit-event (with a bit of convenience) into Logs API and makes it user-facing, see open-telemetry/oteps#265 and open-telemetry/opentelemetry-specification#4236 for the context.
This is an early prototype to drive discussions, high-level API feedback is very welcome.