Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Views to metrics SDK #2391

Merged
merged 49 commits into from
Mar 3, 2022
Merged

Adds Views to metrics SDK #2391

merged 49 commits into from
Mar 3, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jan 19, 2022 •
edited by srikanthccv
Loading

Fixes #2247

Fixes #2478

Fixes #2487

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 20, 2022
@ocelotl ocelotl marked this pull request as ready for review January 20, 2022 06:02
@ocelotl ocelotl requested a review from a team January 20, 2022 06:02
@ocelotl ocelotl self-assigned this Jan 20, 2022
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jan 24, 2022
aabmass
aabmass requested changes Feb 2, 2022
View reviewed changes
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/view.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/view.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/view.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/view.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/view.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/view.py Outdated Show resolved Hide resolved
@ocelotl ocelotl force-pushed the issue_2247 branch 2 times, most recently from 1d06181 to f0b908a Compare February 2, 2022 23:40
@ocelotl ocelotl requested review from aabmass and lzchen February 11, 2022 19:08
@ocelotl ocelotl requested review from aabmass and codeboten February 16, 2022 23:52
ocelotl and others added 18 commits February 28, 2022 15:25
@ocelotl ocelotl requested a review from lzchen March 1, 2022 15:14
@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 2, 2022

@aabmass please take a look, your comments have been addressed ✌️

@ocelotl ocelotl merged commit 24bd23d into open-telemetry:main Mar 3, 2022
@ocelotl ocelotl deleted the issue_2247 branch March 3, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary metrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
5 participants
@ocelotl @codeboten @aabmass @lzchen @srikanthccv