Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor current span handling for newly created spans. #198

Merged
merged 6 commits into from
Oct 15, 2019
Merged

Refactor current span handling for newly created spans. #198

merged 6 commits into from
Oct 15, 2019

Commits on Oct 3, 2019

  1. Refactor current span handling for newly created spans. 

    1. Make Tracer.start_span() simply create and start the Span,
   without setting it as the current instance.
2. Add an extra Tracer.start_as_current_span() to create the
   Span and set it as the current instance automatically.
    @carlosalberto
    carlosalberto committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    bf80341 View commit details
    Browse the repository at this point in the history

  2. Update opentelemetry-api/src/opentelemetry/trace/__init__.py 

    Co-Authored-By: Chris Kleinknecht <[email protected]>
    @carlosalberto @c24t
    carlosalberto and c24t authored Oct 3, 2019
    Configuration menu
    Copy the full SHA
    6f7fdd3 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Apply feedback.

    @carlosalberto
    carlosalberto committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    a9dd24e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into start_span_update

    @carlosalberto
    carlosalberto authored Oct 10, 2019
    Configuration menu
    Copy the full SHA
    635f1b9 View commit details
    Browse the repository at this point in the history

  3. Restore the contextmanager behavior for API's start_span(). 

    This is for keeping mypy happy (mostly).
    @carlosalberto
    carlosalberto committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    feb9334 View commit details
    Browse the repository at this point in the history

  4. Apply more feedback.

    @carlosalberto
    carlosalberto committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    aaad6c3 View commit details
    Browse the repository at this point in the history