Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event API should accept Context instead of specific trace_id, span_id, trace_flags #4328

Open
aabmass opened this issue Nov 27, 2024 · 0 comments · May be fixed by #4344
Open

Event API should accept Context instead of specific trace_id, span_id, trace_flags #4328

aabmass opened this issue Nov 27, 2024 · 0 comments · May be fixed by #4344
Labels
api Affects the API package. sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented Nov 27, 2024

See specification here https://github.com/open-telemetry/opentelemetry-specification/blob/v1.39.0/specification/logs/event-api.md#emit-event

Right now we accept specific fields from SpanContext which doesn't handle extra context stuff like baggage

opentelemetry-python/opentelemetry-api/src/opentelemetry/_events/__init__.py

Lines 38 to 40 in 2ddb076

trace_id: Optional[int] = None,
span_id: Optional[int] = None,
trace_flags: Optional["TraceFlags"] = None,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the API package. sdk Affects the SDK package.
Projects
Python Logging API/SDK RC
Status: Todo
Milestone
No milestone
1 participant
@aabmass