Response success status validated incorrectly #4338
Labels
bug
Something isn't working
Comments
11 tasks
|
zipkin doesn't define its HTTP POST status as returning 204, rather 202 as the code already does. https://github.com/openzipkin/zipkin-api/blob/master/zipkin-api.yaml#L83 What product is returning 204? Can you raise an issue with them to switch it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe your environment
OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)
What happened?
There are some places, where success status of the request validated based on only 200 and 202 status code:
opentelemetry-python/exporter/opentelemetry-exporter-zipkin-json/src/opentelemetry/exporter/zipkin/json/__init__.py
Line 94 in 6812da2
opentelemetry-python/exporter/opentelemetry-exporter-zipkin-proto-http/src/opentelemetry/exporter/zipkin/proto/http/__init__.py
Line 91 in 6812da2
Steps to Reproduce
Receive the HTTP 204 succes status code
Expected Result
204 status to be treated as a success status
Actual Result
204 status code treated as an error
Additional context
Relevant issue (fixed) about the same behavior in another module: #3621
Would you like to implement a fix?
None
The text was updated successfully, but these errors were encountered: