Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Otel Spec forbids B3 propagator from propagating X-B3-ParentSpanId #2231

Closed
owais opened this issue Oct 20, 2021 · 1 comment · Fixed by #2237
Closed

Otel Spec forbids B3 propagator from propagating X-B3-ParentSpanId #2231

owais opened this issue Oct 20, 2021 · 1 comment · Fixed by #2237
Assignees
@JamesJHPark
Labels
good first issue Good first issue help wanted specification

Comments

@owais
Copy link
Contributor

owais commented Oct 20, 2021

From the spec

MUST NOT propagate X-B3-ParentSpanId as OpenTelemetry does not support reusing the same id for both sides of a request.

But we do it here

This should be removed as the spec forbids it.
@owais owais added bug Something isn't working specification good first issue Good first issue help wanted and removed bug Something isn't working labels Oct 20, 2021
@JamesJHPark
Copy link
Contributor

please assign me this issue. Thank you.

@JamesJHPark JamesJHPark mentioned this issue Oct 25, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesJHPark JamesJHPark

Labels
good first issue Good first issue help wanted specification
Projects
None yet
Milestone
No milestone
2 participants
@owais @JamesJHPark