Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentracing shim not connecting "follows from" relationship properly #2179

Closed
robertsben opened this issue Oct 5, 2021 · 0 comments · Fixed by #2180
Closed

opentracing shim not connecting "follows from" relationship properly #2179

robertsben opened this issue Oct 5, 2021 · 0 comments · Fixed by #2180
Labels
bug Something isn't working

Comments

@robertsben
Copy link
Contributor

Describe your environment
The environment can be fully reproduced with this project. Python 3, opentelemetry 1.5.0, shim 0.24b0.

Steps to reproduce
To reproduce the problem you need to create a follows_from relationship trace, like you would find in a pub sub application architecture, and see how there is only a link in opentelemetry, where opentracing treats the link more like a weak child.

A minimal working example is provided here.

What is the expected behavior?
You would expect to see a follows from trace (in opentracing) looking like this, in the Jaeger UI:
Screenshot 2021-10-05 at 15 01 08

What is the actual behavior?
Instead, with opentelemetry (and the shim), you get a weak link that doesn't display the traces together:
Screenshot 2021-10-05 at 15 02 32
Screenshot 2021-10-05 at 15 02 45

Additional context
In the python jaeger-client the relationship between follows from traces is treated as a weak parental relationship deliberately.

@robertsben robertsben added the bug Something isn't working label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant