Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSGI integration does nonstandard split between http.host and http.url #143

Closed
Oberon00 opened this issue Sep 17, 2019 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@Oberon00
Copy link
Member

Oberon00 commented Sep 17, 2019

See https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/data-semantic-conventions.md#http-server and https://github.com/open-telemetry/opentelemetry-python/blob/master/ext/opentelemetry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py#L49-L56.

Even though the code seems right (apart from removing the query which should be included according to spec and adding a nonstandard http.host attribute), using a dumb flask example app (not the one from this repo, but that should work too), this resulted for me

k t v
http.url str /hello-opentelemetry
http.host str localhost:5000

Maybe there is a bogus value in one of the environment variables.

I will hopefully have time to investigate tomorrow, but if someone is quicker, fell free to take this issue.

@Oberon00 Oberon00 added the bug Something isn't working label Sep 17, 2019
@Oberon00
Copy link
Member Author

CC @a-feld

@Oberon00
Copy link
Member Author

@Oberon00 Oberon00 self-assigned this Sep 18, 2019
Oberon00 added a commit to dynatrace-oss-contrib/opentelemetry-python that referenced this issue Sep 18, 2019
Oberon00 added a commit to dynatrace-oss-contrib/opentelemetry-python that referenced this issue Sep 18, 2019
@Oberon00 Oberon00 mentioned this issue Sep 18, 2019
Oberon00 added a commit to dynatrace-oss-contrib/opentelemetry-python that referenced this issue Sep 19, 2019
Oberon00 added a commit to dynatrace-oss-contrib/opentelemetry-python that referenced this issue Sep 19, 2019
Oberon00 added a commit to dynatrace-oss-contrib/opentelemetry-python that referenced this issue Sep 24, 2019
@Oberon00
Copy link
Member Author

Oberon00 commented Sep 26, 2019

Due to the squash-merge, the issue did not get closed automatically by #148, closing it now (note that the related #173 is also merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant