Tornado instrumetnation status_code 4ever 500 if error exsist

[nicholasgribanov]

Here https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py#L372-L379, when span finished, status_code is setting to 500, if error exists and status code from handler not equals 404.
Is it correct behavior ?
I see, it needed for setting description in Status. But, in this method, if status_code <=499, Status must be set to UNSET. In our case, if status_code <=499 will set ERROR.

opentelemetry-python-contrib/opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py

Lines 62 to 63 in dbb35a2

	if status <= 499 and server_span:
	return StatusCode.UNSET

.
Maybe needed extend this condition https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py#L372 to all 4xx http codes instead of just 404?

[srikanthccv]

@nicholasgribanov It was unclear from the description what is the problem here? Can you explain what is the issue and how does the proposed solution fixes the issue?

[nicholasgribanov]

@srikanthccv thank's for a fast answer.
In case, if I want to sampling spans on collector-level by processing with like this config:

  [
    {
      name: error_policy,
      type: numeric_attribute,
      numeric_attribute: { key: "http.status_code", min_value: 500, max_value: 599 }
    }
  ]

I wait spans only with http-status more when 500. But, now, it doesn't work. Beacause, on the Tornado instrumentation level, server spans with error and http-status not equal 404, will forcibly setting http.status_code to 500 https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py#L372-L379.
You can see this here:

It's not right behavior. If you are waiting spans onlyf with http-status more than 500, you must not getting spans with 400 error.
I see, it needed for setting description in Status. But, in this method, if status_code <=499, Status must be set to UNSET. In our case, if status_code <=499 will set ERROR.

opentelemetry-python-contrib/opentelemetry-instrumentation/src/opentelemetry/instrumentation/utils.py

Lines 62 to 63 in dbb35a2

	if status <= 499 and server_span:
	return StatusCode.UNSET

I propose fix this and not change http.status_code, only for setting description message. Now I see, fix from my previusly message not right. Needed find way set descpription of error and not chage http.status_code.

[ocelotl]

Ok, I see there is a discrepancy. I actually wonder why do we change the status code from 4XX to 500, @owais, do you have any input?

[nicholasgribanov]

Any updates ?