-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Span Attributes: http.url
must not contain username / password
#367
Comments
Thanks for filing this! Moving this issue to the contrib repo as I don't believe anything in the core repo sets this attribute. |
This issue was marked stale due to lack of activity. It will be closed in 30 days. |
Hi @codeboten is this issue still open? I'd love to take on my first issue and be assigned to it. I noticed that its been fixed in other language implementations but not here yet. cc: @alolita |
Yup, still open, all yours. |
This should be closed, right? @codeboten |
@marcorichetta @ryokather |
I found this issue while doing a separate check for if I agree with @lzchen; the use of remove_url_credentials util by several instrumentation libraries is already sanitizing It seems like the |
@tammy-baylis-swi |
As is stated in the recent specification change :
The text was updated successfully, but these errors were encountered: