Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redis] RedisCluster support #1167

Closed
sungwonh opened this issue Jun 27, 2022 · 2 comments · Fixed by #1177
Closed

[Redis] RedisCluster support #1167

sungwonh opened this issue Jun 27, 2022 · 2 comments · Fixed by #1177

Comments

@sungwonh
Copy link
Contributor

Redis instrumentation does not support RedisCluster (redis.asyncio.cluster.RedisCluster).

I tried to instrument RedisCluster using opentelemetry-instrumentation-redis as below, but the application did not export any traces related redis.

from opentelemetry.instrumentation.redis import RedisInstrumentor
from redis.asyncio.cluster import RedisCluster as Redis

RedisInstrumentor().instrument()

client = await Redis(host=host, port=6379)

client.get("my-key")

It would be very helpful if redis instrumentation supports RedisCluster.

@srikanthccv
Copy link
Member

@sungwonh Would you like send a PR for this? The important part is to write wrapper functions for cluster similar to this.

@sungwonh
Copy link
Contributor Author

sungwonh commented Jul 1, 2022

@srikanthccv OK. I will send a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants